Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon Assets are missing and equipped weapon icons are not displayed on Battle Embed #144

Open
MiraBellierr opened this issue Mar 21, 2023 · 0 comments

Comments

@MiraBellierr
Copy link
Owner

The current implementation of the battle system in our project lacks the necessary weapon assets for all weapons, resulting in a disparity in the user experience. Furthermore, the equipped weapon icons are not displayed on the battle embed, making it difficult for users to keep track of their current weapons during battles.

To address this problem, we must create the missing weapon assets and ensure their proper integration into the system. We also need to add the ability to display equipped weapon icons on the battle embed so that users can easily see which weapons they have equipped.

This issue is critical for the battle system's proper operation and will significantly improve the user experience.

The implementation should start at \jasmine\src\utils\rpg\battle\Battle.js 466:5

The implementation code has initialized in the file

// Get all equipments from player and opponent
const playerEquipments = JSON.parse(this.character.equipments);
const opponentEquipments = JSON.parse(this.opponent.equipments);

let playerEquipped = [];
let opponentEquipped = [];

// Push all equipped equipments from player and opponent equipments to playerEquipped and opponentEquipped respectively
["weapon", "shields", "helmet", "armor", "gloves"].forEach((e) => {
    playerEquipped.push(playerEquipments[e].equipped);
    opponentEquipped.push(opponentEquipments[e].equipped);
});

// TODO: Get icons for every equipped equipments from player and oppponent
// TODO: Display icons on the battle embed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant