Improve Gradle configuration cache support #867
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves configuration cache support
marchermans
reviewed
Aug 10, 2022
There was a problem hiding this comment.
This looks okey....ish.
That said how much do we need of this @SizableShrimp with regards to gradle 8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves support for Gradle's configuration cache feature by reducing
getProject()usages and marking incompatible tasks accordingly so that the configuration cache can be used for compatible tasks.Note that this is my first time working on a Gradle plugin, so merge with caution - please perform your own tests (I might've overlooked something) and let me know if I've missed anything or done something wrong so that I can improve. :)