-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out of bounds read in sysex commands #190
Comments
sezero
added a commit
that referenced
this issue
Mar 26, 2018
Applied 15e59fa to fix this. Interestingly valgrind does not complain, but ASAN does. Thanks. |
Do we have enough for a 0.4.3? :) |
There's still bug #189 but those glitches were always there. i.e. they are no regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not exploitable, useless out of bounds read behind the sysex_store array by up to 8 bytes.
Found by ASAN while playing the following midi file:
viprpgsz1231.zip
The sysex message is "7f 7f 4 1 0 64 f7" (size = 7).
THe problem is here:
wildmidi/src/internal_midi.c
Lines 2420 to 2426 in 7b87c60
Because sysex store has only a size of 7 the memcmp with 8 reads out of bounds.
Potential fix: Check for sysex_len >= 5 (1st if) and sysex_len >= 8 (2nd if).
RPG Maker games are really great for collecting bad files, already my third report :D
The text was updated successfully, but these errors were encountered: