-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAR Text Support #106
Comments
This could be done ... once I get a response to my question in #80 |
Found a kar archive (30,000+ files) so now I have plenty to test with when I start getting this happening in the library ... someone else can fight with the player once it is in the library. |
Awesome. :) |
With the closing of #80 this is one step closer to being realised. One issue I have noticed is that KAR files will mostly use the TEXT meta event instead of the LYRIC one. You do get the odd one that does use LYRIC as it should so going to have to think about how to handle that. There is no API at the moment that can expose the lyrics, but they are stored within the events. Waiting for us to discuss how best to do this ... Two options exist with both having the same solution (believe it or not). Option 1: Once KAR file is opened call an API that returns lyrics + sample timings in a struct array Option 2: call an API that looks ahead so many samples and returns lyrics + sample timings in a struct array Both options could be serviced by the same API, for example struct _lyrics { Thoughts? |
A surprise awaits in -updates |
The current functionality will stay as a proof of concept. The function I suggested in here will be slated for 0.4.1. |
yay :) |
@chrisisonwildcode: can this be closed? Supports seems to be in 0.4 right? :) |
Leave this one open since for 0.4.1 I plan on having an API that returns a struct array containing lyrics and timings (sample offset from start). Sent from my iPhone
|
@chrisisonwildcode did this ever get into 0.4 or is this still planned for 0.4.1? |
There is kar text support in the lib, but experimental. There are key press options in the player. What I have found so far is that the text can be in one of two meta events. I will attempt to work out a detection so you don't have to manually switch Whitchurch meta it reads from. Sent from my iPhone
|
um … ok, must be waiting on me to do the auto detect, because it is in the player and therefore in the lib. But at the moment if its not using the proper lyric event then its using another event. Problem is the other event can be used for other things as well. Might have to do some logic during loading that says if nothing in lyric but multiple text event present then treat the text event as lyrics. Thoughts? Edit: fix typo's from tired typing. |
Related to issue: #79
We should allow the ability to dump the lyrics, expose the text in a struct and/or allow the display of text in our player.
The text was updated successfully, but these errors were encountered: