Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of snarky js test in mina as one of step of spitting repos #14612

Closed
wants to merge 6 commits into from
Closed

Removal of snarky js test in mina as one of step of spitting repos #14612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bac42e9
Removal of snarky js test in mina as one of step of spitting repos
dkijania Oct 10, 2023
2ae8d96
Merge branch 'rampup' into dkijania/port_remove_snarkyjs_test_rampup
dkijania Nov 29, 2023
e75e451
Merge branch 'rampup' into dkijania/port_remove_snarkyjs_test_rampup
dkijania Dec 6, 2023
0b5e0c2
Merge branch 'rampup' into dkijania/port_remove_snarkyjs_test_rampup
dkijania Dec 14, 2023
5f3b15b
Merge branch 'rampup' into dkijania/port_remove_snarkyjs_test_rampup
dkijania Dec 15, 2023
45318c7
Merge branch 'rampup' into dkijania/port_remove_snarkyjs_test_rampup
dkijania Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions buildkite/src/Command/TestExecutive.dhall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,41 +28,5 @@ in
key = "integration-test-${testName}",
target = Size.Integration,
depends_on = dependsOn
},

buildJs = \(duneProfile : Text) ->
Command.build
Command.Config::{
commands =
-- Build js test archive
RunInToolchain.runInToolchainBuster ([] : List Text) "./buildkite/scripts/build-js-tests.sh"

#

[
-- Cache js test archive
Cmd.run "artifact-cache-helper.sh snarkyjs_test.tar.gz --upload"
],
label = "Build JS integration tests",
key = "build-js-tests",
target = Size.XLarge
},

executeWithJs = \(testName : Text) -> \(dependsOn : List Command.TaggedKey.Type) ->
Command.build
Command.Config::{
commands =
[
Cmd.run "artifact-cache-helper.sh snarkyjs_test.tar.gz && tar -xzf snarkyjs_test.tar.gz",

-- Execute test based on BUILD image
Cmd.run "MINA_DEB_CODENAME=bullseye ; source ./buildkite/scripts/export-git-env-vars.sh && ./buildkite/scripts/run-test-executive.sh ${testName}"
],
artifact_paths = [SelectFiles.exactly "." "${testName}.test.log"],
label = "${testName} integration test",
key = "integration-test-${testName}",
target = Size.Integration,
depends_on = dependsOn,
soft_fail = Some (B/SoftFail.Boolean True)
}
}
9 changes: 1 addition & 8 deletions buildkite/src/Jobs/Test/TestnetIntegrationTests.dhall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ let dependsOn = [
{ name = "MinaArtifactBullseye", key = "daemon-berkeley-bullseye-docker-image" },
{ name = "MinaArtifactBullseye", key = "archive-bullseye-docker-image" }
]
let dependsOnJs = [
{ name = "TestnetIntegrationTests", key = "build-js-tests" },
{ name = "MinaArtifactBullseye", key = "daemon-berkeley-bullseye-docker-image" },
{ name = "MinaArtifactBullseye", key = "archive-bullseye-docker-image" }
]

in Pipeline.build Pipeline.Config::{
spec =
Expand All @@ -31,7 +26,6 @@ in Pipeline.build Pipeline.Config::{
mode = PipelineMode.Type.Stable
},
steps = [
TestExecutive.buildJs "integration_tests",
TestExecutive.execute "peers-reliability" dependsOn,
TestExecutive.execute "chain-reliability" dependsOn,
TestExecutive.execute "payment" dependsOn,
Expand All @@ -42,7 +36,6 @@ in Pipeline.build Pipeline.Config::{
TestExecutive.execute "zkapps" dependsOn,
TestExecutive.execute "zkapps-timing" dependsOn,
TestExecutive.execute "zkapps-nonce" dependsOn,
TestExecutive.execute "verification-key" dependsOn,
TestExecutive.executeWithJs "snarkyjs" dependsOnJs
TestExecutive.execute "verification-key" dependsOn
]
}
70 changes: 0 additions & 70 deletions src/app/test_executive/snarkyjs.ml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/app/test_executive/test_executive.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ let tests : test list =
, (module Verification_key_update.Make : Intf.Test.Functor_intf) )
; ( "block-prod-prio"
, (module Block_production_priority.Make : Intf.Test.Functor_intf) )
; ("snarkyjs", (module Snarkyjs.Make : Intf.Test.Functor_intf))
; ("block-reward", (module Block_reward_test.Make : Intf.Test.Functor_intf))
; ("hard-fork", (module Hard_fork.Make : Intf.Test.Functor_intf))
]
Expand Down