Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#31: Add support for shimming operators #33

Merged
merged 32 commits into from
Jun 6, 2024

Conversation

Miista
Copy link
Owner

@Miista Miista commented Jan 28, 2024

Closes #31

@Miista Miista linked an issue Jan 28, 2024 that may be closed by this pull request
8 tasks
@Miista Miista force-pushed the 31-add-support-for-shimming-operators branch from f70f19d to f8d961f Compare January 28, 2024 18:36
@Miista Miista mentioned this pull request Jan 28, 2024
8 tasks
@Miista Miista force-pushed the 31-add-support-for-shimming-operators branch 2 times, most recently from 9c94c4c to 03810ac Compare March 5, 2024 10:21
@Miista Miista linked an issue Mar 5, 2024 that may be closed by this pull request
Miista added 24 commits May 2, 2024 14:27
Please note, though, that the shim cannot be applied to a specific instance as the operator is static.
We now support:
* Comparison
* Equality
* Most of arithmetic
We now support:
* +
* ++
* -
* --
* ~
* true
* false
…from-within-posecontextisolate

#26: Enum.IsDefined cannot be called from within PoseContext.Isolate
We now target the following frameworks:
- net47
- net48
- netcoreapp2.0
- netcoreapp3.0
- netcoreapp3.1
- net6.0
- net7.0
- net8.0
@Miista Miista force-pushed the 31-add-support-for-shimming-operators branch from 289fa45 to 55f4068 Compare May 2, 2024 12:29
@stoyanov-x
Copy link

@Miista Thank you for your continuous improvements upon the original codebase.

Can you please clarify why these two PRs (#33 and #29) are still open? From what I understand, they can theoretically be merged in your own fork of the pose library.

On a related note, can you please integrate these two changes tonerdo/pose#74 + tonerdo/pose#62 into your fork?

@Miista
Copy link
Owner Author

Miista commented Jun 6, 2024

@stanimirsellercloud @stoyanov-x #29 is still open because support is not complete. As for #33 (this PR), it will be merged today. I just have to shuffle around the releases.

As for the changes in tonerdo/pose#74; they are already in this fork. There is explicit support for the following target frameworks:

  • .NET Framework 4.8
  • .NET Standard 2.0
  • .NET Core 2.0
  • .NET Core 3.0
  • .NET 7
  • .NET 8

Regarding tonerdo/pose#62 I am a bit unsure what it does and what is required by this fork. Perhaps you can elaborate in a new issue?

@Miista Miista modified the milestone: v2.1 Jun 6, 2024
@Miista Miista merged commit 466ff43 into master Jun 6, 2024
1 check passed
@Miista Miista deleted the 31-add-support-for-shimming-operators branch June 6, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand test coverage Add support for shimming operators
2 participants