-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#31: Add support for shimming operators #33
Conversation
f70f19d
to
f8d961f
Compare
9c94c4c
to
03810ac
Compare
Please note, though, that the shim cannot be applied to a specific instance as the operator is static.
We now support: * Comparison * Equality * Most of arithmetic
We now support: * + * ++ * - * -- * ~ * true * false
…from-within-posecontextisolate #26: Enum.IsDefined cannot be called from within PoseContext.Isolate
Update Poser.nuspec
Update badges in README
…-support-for-shimming-operators
We now target the following frameworks: - net47 - net48 - netcoreapp2.0 - netcoreapp3.0 - netcoreapp3.1 - net6.0 - net7.0 - net8.0
This is due to being unable to represent them in an expression tree.
289fa45
to
55f4068
Compare
@Miista Thank you for your continuous improvements upon the original codebase. Can you please clarify why these two PRs (#33 and #29) are still open? From what I understand, they can theoretically be merged in your own fork of the On a related note, can you please integrate these two changes tonerdo/pose#74 + tonerdo/pose#62 into your fork? |
@stanimirsellercloud @stoyanov-x #29 is still open because support is not complete. As for #33 (this PR), it will be merged today. I just have to shuffle around the releases. As for the changes in tonerdo/pose#74; they are already in this fork. There is explicit support for the following target frameworks:
Regarding tonerdo/pose#62 I am a bit unsure what it does and what is required by this fork. Perhaps you can elaborate in a new issue? |
Closes #31