Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in changes from tonerdo/pose#62 #50

Open
Miista opened this issue Jun 6, 2024 · 10 comments
Open

Bring in changes from tonerdo/pose#62 #50

Miista opened this issue Jun 6, 2024 · 10 comments
Assignees
Labels
question/investigation Further information or investigation is required

Comments

@Miista
Copy link
Owner

Miista commented Jun 6, 2024

@stanimirsellercloud @stoyanov-x #29 is still open because support is not complete. As for #33 (this PR), it will be merged today. I just have to shuffle around the releases.

As for the changes in tonerdo/pose#74; they are already in this fork. There is explicit support for the following target frameworks:

  • .NET Framework 4.8
  • .NET Standard 2.0
  • .NET Core 2.0
  • .NET Core 3.0
  • .NET 7
  • .NET 8

Regarding tonerdo/pose#62 I am a bit unsure what it does and what is required by this fork. Perhaps you can elaborate in a new issue?

Originally posted by @Miista in #33 (comment)

@Miista
Copy link
Owner Author

Miista commented Jun 6, 2024

@stoyanov-x We can continue the discussion here :)

@Miista Miista added the question/investigation Further information or investigation is required label Jun 6, 2024
@Miista
Copy link
Owner Author

Miista commented Jun 29, 2024

Perhaps @JTOne123 can shed some more light on this.

@JTOne123
Copy link

JTOne123 commented Jul 1, 2024

Hi @Miista , I do know nothing about this project, sorry.

@Miista
Copy link
Owner Author

Miista commented Jul 1, 2024

Hi @JTOne123, I mentioned you in this issue because I believe you are the author of the original PR here: tonerdo/pose#62

@Miista
Copy link
Owner Author

Miista commented Jul 4, 2024

@JTOne123 If this doesn't ring a bell, just let me know :)

@JTOne123
Copy link

JTOne123 commented Jul 5, 2024

@Miista As I said I do know nothing about this proj and repo.

@Miista
Copy link
Owner Author

Miista commented Jul 6, 2024

@JTOne123 Noted. Thank you! :)

@stoyanov-x Unless we can get more information about this I will close this issue.

@Miista Miista self-assigned this Jul 6, 2024
@Laniusexcubitor
Copy link

What the mentioned PR does, is enable Sourcelink for the package, allowing easy debugging of the package.
Just like sourcestepping for the .NET source code.
With a correctly configured IDE, you can just step into the code of the library because it can automatically find the source on github.

But to be honest, if the PR author is not interested in this anymore I would ditch the PR ;)

@Miista
Copy link
Owner Author

Miista commented Sep 12, 2024

@Laniusexcubitor I believe this should already be possible as I am including the debug symbols in the released package.

In any case I will close the issue as you suggested.

@Laniusexcubitor
Copy link

Seems the author used an automation tool to bulk create those pull requests in any repo found on nuget. So this wasn't tested anyway. Probably no problem for those changes. But that's what people always think, for "no brainer"-changes :)

If you have the symbols in the released package. Adding the Sourcelink.github package would help finding the sourcecode using those symbols. This enables auto download of the source files in the debugger.
Putting the symbols in a separate snupkg, would enable on demand download of the symbols. But then the snupkg would need deployment to nuget.org alongside the nupkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question/investigation Further information or investigation is required
Projects
None yet
Development

No branches or pull requests

3 participants