-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in changes from tonerdo/pose#62 #50
Comments
@stoyanov-x We can continue the discussion here :) |
Perhaps @JTOne123 can shed some more light on this. |
Hi @Miista , I do know nothing about this project, sorry. |
Hi @JTOne123, I mentioned you in this issue because I believe you are the author of the original PR here: tonerdo/pose#62 |
@JTOne123 If this doesn't ring a bell, just let me know :) |
@Miista As I said I do know nothing about this proj and repo. |
@JTOne123 Noted. Thank you! :) @stoyanov-x Unless we can get more information about this I will close this issue. |
What the mentioned PR does, is enable Sourcelink for the package, allowing easy debugging of the package. But to be honest, if the PR author is not interested in this anymore I would ditch the PR ;) |
@Laniusexcubitor I believe this should already be possible as I am including the debug symbols in the released package. In any case I will close the issue as you suggested. |
Seems the author used an automation tool to bulk create those pull requests in any repo found on nuget. So this wasn't tested anyway. Probably no problem for those changes. But that's what people always think, for "no brainer"-changes :) If you have the symbols in the released package. Adding the Sourcelink.github package would help finding the sourcecode using those symbols. This enables auto download of the source files in the debugger. |
@stanimirsellercloud @stoyanov-x #29 is still open because support is not complete. As for #33 (this PR), it will be merged today. I just have to shuffle around the releases.
As for the changes in tonerdo/pose#74; they are already in this fork. There is explicit support for the following target frameworks:
Regarding tonerdo/pose#62 I am a bit unsure what it does and what is required by this fork. Perhaps you can elaborate in a new issue?
Originally posted by @Miista in #33 (comment)
The text was updated successfully, but these errors were encountered: