Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchViewListener wrong state in the callbacks #237

Open
hegazy opened this issue Jun 21, 2019 · 0 comments
Open

SearchViewListener wrong state in the callbacks #237

hegazy opened this issue Jun 21, 2019 · 0 comments

Comments

@hegazy
Copy link

hegazy commented Jun 21, 2019 •
edited
Loading

When checking isSearchShown from onSearchViewClosed or onSearchViewShown, the state is wrong as the internal state boolean only gets changed after executing the callback.

https://github.com/MiguelCatalan/MaterialSearchView/blob/develop/library/src/main/java/com/miguelcatalan/materialsearchview/MaterialSearchView.java#L532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hegazy