Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage is not 100% #4

Open
domi41 opened this issue Jul 7, 2021 · 2 comments
Open

Coverage is not 100% #4

domi41 opened this issue Jul 7, 2021 · 2 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@domi41
Copy link
Contributor

domi41 commented Jul 7, 2021

There are two lines that are not covered by test-cases, and I don't know what to do with them.

If you see GitHub API: Forbidden, it's a CodeCov issue ; you can manually copy the link and open it in a new tab, it should work : https://codecov.io/gh/MieuxVoter/majority-judgment-library-go/src/main/majorityjudgment.go#L128

These two lines handle error propagation, and I don't expect an error (since the algorithm should be correct), and I can't even trigger it.

Nevertheless, it feels like we should not remove that error handling, even if it means we don't get 100%.

@domi41 domi41 added help wanted Extra attention is needed question Further information is requested labels Jul 7, 2021
@domi41
Copy link
Contributor Author

domi41 commented Jul 9, 2021

A solution would perhaps be to ignore errors in RegradeJudgments, and not expose it.

@domi41
Copy link
Contributor Author

domi41 commented Feb 19, 2023

Oh, and the late addition of colors also broke the 99% coverage.
These need more work, I'm not fond of the local panic() usage anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant