Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Update setup.py and add requirements.txt #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardkmichael
Copy link

The Azimuth code is not likely to be updated, so add explicit dependencies on specific working versions of pandas, numpy, etc. to simplify installation.

Also add dependencies for pip install -r requirements.txt.

Changes to numpy and pandas since this code was originally written cause a
`ValueError`, breaking an `assert` in the model comparison code.  Appears due to
numpy beginning to delegate to pandas for `.any()` (and other functions), which
itself returns a Series instead of single boolean, resulting in error "Truth
value of a Series is ambiguous".  Pin numpy and pandas at the versions which
work.

Also add missing xlrd dependency, required during model training.

Create `requirements.txt` for pip to give absolute dependency clarity and
simplify installation.
@msftclas
Copy link

msftclas commented Mar 24, 2020

CLA assistant check
All CLA requirements met.

Copy link

@sawravchy sawravchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants