Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think the page is outdated #3139

Closed
madhaven opened this issue Apr 29, 2024 · 4 comments
Closed

I think the page is outdated #3139

madhaven opened this issue Apr 29, 2024 · 4 comments
Labels
ADO cat: pwas Progressive Web Apps-related content needs-more-info

Comments

@madhaven
Copy link

madhaven commented Apr 29, 2024

  • The documentation talks about a manifest file but that exists only in the dist folder. That does not make sense.
    image
  • The app.js file contains only three references to the navigator.
    I was not able to access this API.

Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

AB#50475498

@captainbrosset captainbrosset added cat: pwas Progressive Web Apps-related content ADO and removed triage-needed labels Apr 30, 2024
@captainbrosset
Copy link
Contributor

Thanks for filing this issue. I've added it to our backlog. We'll take a look and try to make the page clearer/more up to date.

@captainbrosset
Copy link
Contributor

  • The documentation talks about a manifest file but that exists only in the dist folder. That does not make sense.

The manifest file is correctly linked to from the docs: https://github.com/MicrosoftEdge/Demos/blob/main/1DIV/dist/manifest.json
Indeed, it's in the dist folder, because it's a static file that doesn't require to be built with WebPack, like the other JS files that are in the src folder.

Can you elaborate on what doesn't make sense for you here?

  • The app.js file contains only three references to the navigator.
    I was not able to access this API.

The app.js file does use the navigator.windowControlsOverlay API, as shown here: https://github.com/MicrosoftEdge/Demos/blob/main/1DIV/src/app.js#L299-L301

So, thinking about this again, I'm not sure what's the source of the confusion here. Can you please elaborate on what changes you'd like us to make in order to make this article clearer?

@madhaven
Copy link
Author

madhaven commented May 27, 2024

Thank you @captainbrosset for clarifying.

I was of the impression that the manifest file should be on top like in an Electron-app, it was weird to find the manifest in the distributable.

The navigator was still not accessible from my Electron scripts, is there a way for an Electron app to access the Window Controls Overlay?

@captainbrosset
Copy link
Contributor

No, the Window Controls Overlay is a PWA feature only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO cat: pwas Progressive Web Apps-related content needs-more-info
Projects
None yet
Development

No branches or pull requests

2 participants