SortOrder vs SortOrderInput

[ericwink]

Hi folks,

I'm upgrading from older dependencies, and now running current Prisma Typegraphql I'm seeing a discrepancy in how OrderBy is handled when compared to previous versions.

It seems that if something is marked as required in my Prisma Model, the generated OrderBy file assigns the following:

  @TypeGraphQL.Field(_type => SortOrder, {
    nullable: true
  })
  name?: "asc" | "desc" | undefined;

However, if something is marked as optional in my Prisma schema, it results in the following:

  @TypeGraphQL.Field(_type => SortOrderInput, {
    nullable: true
  })
  name?: SortOrderInput | undefined;

SortOrderInput is defined as...

export class SortOrderInput {
  @TypeGraphQL.Field(_type => SortOrder, {
    nullable: false
  })
  sort!: "asc" | "desc";

  @TypeGraphQL.Field(_type => NullsOrder, {
    nullable: true
  })
  nulls?: "first" | "last" | undefined;
}

This is challenging, as when trying to allow dynamic sorting controlled by the user, I don't know how to determine when I can just pass orderBy: [{key: 'asc'}] or when I need to pass orderBy: [{key: {sort: 'asc'}}]

Is there any way to make everything follow just the SortOrder logic?

Thank you!

[MichalLytek]

The logic is as you see - for nullable columns you can sort by nulls. There's no abstraction to unify this.

[ericwink]

Thanks so much for the quick reply! Knowing my options helps me focus on the path forward so this was definitely helpful. And thank you for all of your great work!