From 662792d097ee6459b25783dad084e514b87b2ebe Mon Sep 17 00:00:00 2001
From: lawvs <18554747+lawvs@users.noreply.github.com>
Date: Thu, 14 Dec 2023 18:25:47 +0800
Subject: [PATCH 1/2] feat: add type check

---
 .github/workflows/build.yml | 3 +++
 package.json                | 1 +
 2 files changed, 4 insertions(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2708cbc..9fc385b 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -33,6 +33,9 @@ jobs:
       - name: Lint
         run: nr style
 
+      - name: Type check
+        run: nr typecheck
+
       - name: Build
         run: nr build
 
diff --git a/package.json b/package.json
index 4bb8b69..ed3f95d 100644
--- a/package.json
+++ b/package.json
@@ -7,6 +7,7 @@
     "prepare": "husky install",
     "dev": "vite build --watch",
     "build": "vite build",
+    "typecheck": "tsc --noEmit",
     "style": "prettier --check \"src/**/*.{ts,tsx}\"",
     "style:fix": "prettier --write \"src/**/*.{ts,tsx}\""
   },

From 7c2ff3cd430412634941955d08a8e2fbdd1d1f2c Mon Sep 17 00:00:00 2001
From: lawvs <18554747+lawvs@users.noreply.github.com>
Date: Thu, 14 Dec 2023 18:26:32 +0800
Subject: [PATCH 2/2] fix: type

---
 src/background.ts |  6 +++---
 src/popup.tsx     | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/background.ts b/src/background.ts
index d4fa47c..620f85f 100644
--- a/src/background.ts
+++ b/src/background.ts
@@ -20,7 +20,7 @@ chrome.storage.local.get("types", (result) => {
 
 const windowGroupMaps: { [key: number]: Map<string, number> } = {};
 
-chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
+chrome.runtime.onMessage.addListener((message) => {
   chrome.storage.local.get("types", (resultStorage) => {
     if (resultStorage.types) {
       types = resultStorage.types;
@@ -159,7 +159,7 @@ async function handleNewTab(tab: chrome.tabs.Tab) {
 }
 
 async function handleTabUpdate(
-  tabId: number,
+  _tabId: number,
   changeInfo: chrome.tabs.TabChangeInfo,
   tab: chrome.tabs.Tab
 ) {
@@ -185,7 +185,7 @@ async function handleTabUpdate(
 
 chrome.tabs.onCreated.addListener(handleNewTab);
 chrome.tabs.onUpdated.addListener(handleTabUpdate);
-chrome.tabs.onDetached.addListener((tabId, detachInfo) => {
+chrome.tabs.onDetached.addListener((_tabId, detachInfo) => {
   const windowId = detachInfo.oldWindowId;
   if (
     windowGroupMaps.hasOwnProperty(windowId) &&
diff --git a/src/popup.tsx b/src/popup.tsx
index 70b17c4..ee8ef0f 100644
--- a/src/popup.tsx
+++ b/src/popup.tsx
@@ -64,7 +64,7 @@ const Popup = () => {
   };
 
   const enableAutoPosition = () => {
-    setIsAutoPosition((isAutoGroupPosition) => {
+    setIsAutoPosition(() => {
       setStorage("isAutoPosition", !isAutoPosition);
       return !isAutoPosition;
     });
@@ -139,8 +139,8 @@ const Popup = () => {
 
             <button
               disabled={!newType}
-              className="rounded-md w-fit bg-primary/lg px-2.5 py-1.5 text-sm font-semibold 
-            text-white shadow-sm hover:bg-primary focus-visible:outline focus-visible:outline-2 
+              className="rounded-md w-fit bg-primary/lg px-2.5 py-1.5 text-sm font-semibold
+            text-white shadow-sm hover:bg-primary focus-visible:outline focus-visible:outline-2
             focus-visible:outline-offset-2 disabled:bg-primary/sm"
             >
               Add
@@ -177,7 +177,7 @@ const Popup = () => {
       <div className="flex items-center gap-x-4">
         <button
           disabled={!openAIKey || !types || !types.length}
-          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold 
+          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold
         text-white shadow-sm hover:bg-primary focus-visible:outline cursor-pointer
         focus-visible:outline-2 focus-visible:outline-offset-2"
           onClick={getAllTabsInfo}
@@ -187,7 +187,7 @@ const Popup = () => {
         </button>
 
         <button
-          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold 
+          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold
         text-white shadow-sm hover:bg-primary focus-visible:outline cursor-pointer
         focus-visible:outline-2 focus-visible:outline-offset-2"
           onClick={ungroup}