Make symlink path configurable #461
Open
+60
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ let | |||
| type = types.str; | |||
| default = config._module.args.name; | |||
| description = '' | |||
| Name of the file used in /run/secrets | |||
| Name of the file used in /run/secrets (or your configured symlinkPath) | |||
There was a problem hiding this comment.
Suggested change
| Name of the file used in /run/secrets (or your configured symlinkPath) | |
| Name of the file used in /run/secrets or your configured symlinkPath |
| defaultText = "/run/secrets-for-users/$name when neededForUsers is set, /run/secrets/$name when otherwise."; | ||
| description = '' | ||
| Path where secrets are symlinked to. | ||
| If the default is kept no symlink is created. | ||
| If cfg.symlinkPath is set, /run/secrets will become that path |
There was a problem hiding this comment.
Suggested change
| If cfg.symlinkPath is set, /run/secrets will become that path | |
| If `sops.symlinkPath` is set, `/run/secrets` is that path |
I am not sure if I understand this description correct
| type = types.str; | ||
| default = "/run/secrets.d"; | ||
| description = '' | ||
| The location where the secrets are stored. This is then symlinked to cfg.SymlinkPath (default: /run/secrets) |
There was a problem hiding this comment.
Suggested change
| The location where the secrets are stored. This is then symlinked to cfg.SymlinkPath (default: /run/secrets) | |
| The location where the secrets are stored. This is symlinked to sops.SymlinkPath which defaults to `/run/secrets`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There used to be a comment here
sops-nix/modules/sops/default.nix
Line 121 in cfdbaf6
asking whether this needed to be configurable? Well, I needed it to be configurable. So I made it so. I thought I'd contribute the change upstream. What do you think?
I'm sorry, I alro ran autoformat on the file. Maybe that's nice to do on the entire project, though I can undo it if you really want to.
Oh, and feel free to squash. The separate commits don't make that much sense.