From 1e5c2f1d9c9ec4c35544e87ef039cfc8ee06589f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Mon, 20 Nov 2023 12:17:28 +0100 Subject: [PATCH 1/3] drop nix-review note --- README.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index cad737b..da1bb02 100644 --- a/README.md +++ b/README.md @@ -5,8 +5,6 @@ Review pull-requests on https://github.com/NixOS/nixpkgs. nixpkgs-review automatically builds packages changed in the pull requests. -NOTE: this project used to be called `nix-review` - ## Features - [ofborg](https://github.com/NixOS/ofborg) support: reuses evaluation output of @@ -25,8 +23,7 @@ NOTE: this project used to be called `nix-review` ## Installation -`nixpkgs-review` is included in nixpkgs. Older versions of nixpkgs might still -call it `nix-review`. +`nixpkgs-review` is included in nixpkgs. To use it without installing it, use: @@ -225,7 +222,7 @@ corresponding pull request URL is shown. ## Remote builder -Nix-review will pass all arguments given in `--build-arg` to `nix-build`: +Nixpkgs-review will pass all arguments given in `--build-arg` to `nix-build`: ```console $ nixpkgs-review pr --build-args="--builders 'ssh://joerg@10.243.29.170'" 37244 From 7ed3f7225c6e569e4790a52862d9513d4ec6e3e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Mon, 20 Nov 2023 12:18:35 +0100 Subject: [PATCH 2/3] README: update install instructions no longer advertize nix-env. quote nix run usage for zsh users. fixes 'https://github.com/Mic92/nixpkgs-review/issues/377' --- README.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/README.md b/README.md index da1bb02..9336186 100644 --- a/README.md +++ b/README.md @@ -28,13 +28,7 @@ automatically builds packages changed in the pull requests. To use it without installing it, use: ```console -$ nix run nixpkgs#nixpkgs-review -``` - -To install it: - -```console -$ nix-env -f '' -iA nixpkgs-review +$ nix run 'nixpkgs#nixpkgs-review' ``` To run it from the git repository: From 2b9d7f8d12bf9ebc98834cf3fc1324ff35075fab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Mon, 20 Nov 2023 12:19:05 +0100 Subject: [PATCH 3/3] drop outdated comment about black --- README.md | 9 --------- 1 file changed, 9 deletions(-) diff --git a/README.md b/README.md index 9336186..b45e27c 100644 --- a/README.md +++ b/README.md @@ -38,15 +38,6 @@ $ nix-build $ ./result/bin/nixpkgs-review ``` -Note that this asserts formatting with the latest version of -[black](https://github.com/psf/black), so you may need to specify a more up to -date version of nixpkgs: - -```console -$ nix-build -I nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/nixpkgs-unstable.tar.gz -$ ./result/bin/nixpkgs-review -``` - ### Development Environment For IDEs: