You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Trying to review a huge staging PR, I used --skip-package-regex to skip over a few packages that I know wouldn't be broken or that I don't want to build this worked in pr mode. Cloning the PR and trying to run nixpkgs-review rev HEAD -b ... --skip-package-regex ... does not actually skip package names that match the regex which is extremely confusing.
nixpkgs-review should either support --skip-package in rev mode or error out, rather than silently ignoring the flag.
An easy way to repro this is to create a commit touching hello in some way (i.e. breaking it) and then running with --skip-package hello. It should not build anything but in actuality it tries to build hello.
The text was updated successfully, but these errors were encountered:
Trying to review a huge staging PR, I used
--skip-package-regex
to skip over a few packages that I know wouldn't be broken or that I don't want to build this worked in pr mode. Cloning the PR and trying to runnixpkgs-review rev HEAD -b ... --skip-package-regex ...
does not actually skip package names that match the regex which is extremely confusing.nixpkgs-review
should either support--skip-package
inrev
mode or error out, rather than silently ignoring the flag.An easy way to repro this is to create a commit touching
hello
in some way (i.e. breaking it) and then running with--skip-package hello
. It should not build anything but in actuality it tries to build hello.The text was updated successfully, but these errors were encountered: