Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--skip-package-regex and --skip-package-regex do not work in rev mode #363

Closed
Atemu opened this issue Sep 24, 2023 · 1 comment
Closed

Comments

@Atemu
Copy link
Contributor

Atemu commented Sep 24, 2023

Trying to review a huge staging PR, I used --skip-package-regex to skip over a few packages that I know wouldn't be broken or that I don't want to build this worked in pr mode. Cloning the PR and trying to run nixpkgs-review rev HEAD -b ... --skip-package-regex ... does not actually skip package names that match the regex which is extremely confusing.

nixpkgs-review should either support --skip-package in rev mode or error out, rather than silently ignoring the flag.

An easy way to repro this is to create a commit touching hello in some way (i.e. breaking it) and then running with --skip-package hello. It should not build anything but in actuality it tries to build hello.

@Mic92
Copy link
Owner

Mic92 commented Sep 24, 2023

fixed in #364

@Mic92 Mic92 closed this as completed Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants