Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passthru.tests should be run automatically #297

Closed
erikarvstedt opened this issue Dec 29, 2022 · 2 comments
Closed

passthru.tests should be run automatically #297

erikarvstedt opened this issue Dec 29, 2022 · 2 comments

Comments

@erikarvstedt
Copy link

erikarvstedt commented Dec 29, 2022

Package update PR NixOS/nixpkgs#206835 broke the corresponding module (later fixed here).

This could have been prevented if the standard review command (nixpkgs-review pr 206835) would automatically run the package-specific NixOS tests defined in passthru.tests.

Instead, reviewers need to manually run the test with an extra command:

nixpkgs-review pr 206835
nixpkgs-review pr -p nixosTests.paperless 206835

This is error-prone, not least because the NixOS test name can differ from the package name (like in this case).

cc @NobbZ, @SuperSandro2000

@NobbZ
Copy link

NobbZ commented Dec 29, 2022

There should be a way to opt out from running the tests then, as they might involve virtualisation, which might not be available for everyone.

Any generated output, and perhaps the PR template should be adjusted then to also tell whether tests or not have been (successfully) ran.

@Mic92
Copy link
Owner

Mic92 commented Dec 29, 2022

Duplicate of #77

@Mic92 Mic92 marked this as a duplicate of #77 Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants