Mojave tab labels are blurry in dark mode

[ychin]

Mojave-style tabs currently have a blurry drop shadow under the label text that's very visible in Dark Mode, which looks messy. Native tabs do not have that and therefore look a lot cleaner.

From what I can tell the culprit is at the following location:

MMTabBarView/MMTabBarView/MMTabBarView/MMTabBarButtonCell.m

Line 1049 in 172a9d4

[shadow set];

It applies a global drop shadow to all text labels. When I turn it off locally, the text looks normal and much closer to what native tabs look like. I looked at the other styles too and they still looked fine after I removed the drop shadow code so I think this code could probably be removed, but I'm not sure what the original reasoning behind the drop shadow is (did Apple's Aqua/Metal-style tabs have drop shadows?). I think the drop shadow should at least be turned off for Mojave or other more modern tab styles.

[barijaona]

Seems to be solved by #70

[RobFog]

@nivekkagicom Do you think it's the same issue?

[nivekkagicom]

I believe they are the same issue.