Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with current release / build pipeline #99

Open
f00f opened this issue Feb 23, 2018 · 5 comments
Open

Issues with current release / build pipeline #99

f00f opened this issue Feb 23, 2018 · 5 comments

Comments

@f00f
Copy link
Contributor

f00f commented Feb 23, 2018

This list is to summarize all things which went wrong with the latest release (v.11.0).
All are minor issues which are no regression, but would be nice if they were fixed.

@f00f
Copy link
Contributor Author

f00f commented Feb 23, 2018

Log output regarding the Tag

%>echo Tagging the Git Repository ... 
Tagging the Git Repository ...

%>"Scripts\Create Git Release Tag.bat" v.11.0.0.117 
Creating Git Tag for release:
    Remote:   origin
    Tag:      v.11.0.0.117
    Message:  Release v.11.0.0.117 (2018-02-23 17.44)
bash: /dev/tty: No such device or address
error: failed to execute prompt script (exit code 1)
fatal: could not read Username for 'https://github.com': Invalid argument

@f00f
Copy link
Contributor Author

f00f commented Feb 23, 2018

I have created the tag manually for this release.

@jangernert
Copy link
Collaborator

jangernert commented Feb 23, 2018

Regarding the missing meta data of the C++/Cli binaries:

The 'Details' page in Windows Explorer is pulling the information from unmanaged structures in the file, so you'll need to create an unmanaged version resource in order to fill that in.

So in the file app.rc add a new resource Version in which the information can be filled in. However, I am not sure how to reference the version number from SolutionAssemblyInfo.h there.

edit: There seems to be a tool that eases the process

@jangernert
Copy link
Collaborator

Version Number 1.0 of netstandard binaries:
The file AssemblyInfo.cs is explicitly removed from the project.

  <ItemGroup>
    <Compile Remove="Properties\AssemblyInfo.cs" />
    <Compile Remove="Properties\Resources.Designer.cs" />
  </ItemGroup>

I'm not entirely sure why that is. After clarifying that we could potentially revert that change.

@f00f
Copy link
Contributor Author

f00f commented Feb 23, 2018

C++/CLI: yep, we need to add this resource crap

netstandard: cannot handle AssemblyInfo files (I think it complains about duplicate stuff - you can try it locally. the version needs to be in the project file (see Util for reference)

Both are issues which could best be addressed by a script which reads the version number from a file and patches all the rest. Ideally the build job should also be able to parse that file.

@f00f f00f changed the title Issues with current release Issues with current release / build pipeline Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants