Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Release 17.0.0 #474

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Release 17.0.0 #474

merged 1 commit into from
Apr 18, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 16, 2024 •
edited
Loading

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@legobeat legobeat mentioned this pull request Apr 17, 2024
Merged
@legobeat legobeat marked this pull request as ready for review April 17, 2024 11:40
@legobeat legobeat requested a review from a team as a code owner April 17, 2024 11:40
@legobeat legobeat requested review from mcmire, kumavis and Gudahtt April 17, 2024 20:42
Gudahtt
Gudahtt approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md
- Bump ethereumjs and metamask dependencies ([#453](https://github.com/MetaMask/web3-provider-engine/pull/453)) ([#471](https://github.com/MetaMask/web3-provider-engine/pull/471))
- babelify dependencies ([#454](https://github.com/MetaMask/web3-provider-engine/pull/454))
- Update dependency `readable-stream` from `^2.2.9` to `^3.6.2` ([#452](https://github.com/MetaMask/web3-provider-engine/pull/452))
- Update devDependency `browserify` from `16.5.0` to `17.0.0` ([#456](https://github.com/MetaMask/web3-provider-engine/pull/456))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Is this relevant to users of this package? Perhaps we could omit it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does result in a different build output under dist/, which is why I am leaning towards including it.

@legobeat legobeat merged commit c980e52 into main Apr 18, 2024
8 checks passed
@legobeat legobeat deleted the release/17.0.0 branch April 18, 2024 02:41
@legobeat
Copy link
Contributor Author 

npm notice === Tarball Details ===
npm notice name:          web3-provider-engine
npm notice version:       17.0.0
npm notice filename:      web3-provider-engine-17.0.0.tgz
npm notice package size:  896.0 kB
npm notice unpacked size: 4.2 MB
npm notice shasum:        48a24567ff0a33779ddc40be52e9030a9180b4b9
npm notice integrity:     sha512-QKw3WEiF7fxi+[...]Rruncc2vDahsA==
npm notice total files:   74

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire Awaiting requested review from mcmire

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @Gudahtt