Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

fix(subproviders/filters): Rename class from SubscriptionsSubprovider to FiltersSubprovider #442

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 6, 2023

Rename and remove unused constructor param carried over from other class.

@legobeat legobeat requested a review from a team as a code owner September 6, 2023 02:30
@legobeat legobeat changed the title fix(suproviders/filters): Rename class from SubsciptionsSubProvider to FiltersSubProvider fix(suproviders/filters): Rename class from SubscriptionsSubProvider to FiltersSubProvider Sep 6, 2023
@legobeat legobeat changed the title fix(suproviders/filters): Rename class from SubscriptionsSubProvider to FiltersSubProvider fix(suproviders/filters): Rename class from SubscriptionsSubprovider to FiltersSubprovider Sep 6, 2023
@legobeat legobeat changed the title fix(suproviders/filters): Rename class from SubscriptionsSubprovider to FiltersSubprovider fix(subproviders/filters): Rename class from SubscriptionsSubprovider to FiltersSubprovider Oct 10, 2023
@legobeat legobeat requested a review from naugtur October 10, 2023 23:51
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has always bugged me. Makes sense.

@legobeat legobeat merged commit f5a78a9 into MetaMask:main Oct 11, 2023
3 checks passed
@legobeat legobeat deleted the fix-filtersprovider-classname branch October 11, 2023 23:05
@legobeat legobeat mentioned this pull request Oct 11, 2023
legobeat added a commit that referenced this pull request Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants