Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: address regression pipeline slow down #12512

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Dec 2, 2024

Description

The purpose of this PR is to:

  1. Add some critical flow accounts e2e tests to the smoke pipeline
  2. Fix glob for tests tagged SmokeCore
  3. Fix Portfolio dapp connect test.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 2, 2024
@cortisiko cortisiko marked this pull request as ready for review December 2, 2024 23:47
@cortisiko cortisiko requested review from a team as code owners December 2, 2024 23:47
@cortisiko cortisiko enabled auto-merge December 2, 2024 23:51
Copy link

sonarcloud bot commented Dec 2, 2024

@cortisiko cortisiko added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit db3b31e Dec 3, 2024
45 of 46 checks passed
@cortisiko cortisiko deleted the detox/address-regression-tests-slowdown branch December 3, 2024 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants