Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding basic page for typed signatures V3, V4 #12506

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 2, 2024

Description

Adding basic page for types sign V3, V4.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3681

Manual testing steps

  1. Enable re-designs locally
  2. To to test dapp and submit V3, V4 signatures
  3. Check the page that appears

Screenshots/Recordings

Screenshot 2024-12-02 at 5 16 06 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 2, 2024
@jpuri jpuri requested a review from a team as a code owner December 2, 2024 12:21
Copy link
Contributor

github-actions bot commented Dec 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri requested a review from a team as a code owner December 2, 2024 12:53
@jpuri jpuri changed the title feat: adding basic page for typed signatures V3, v4 feat: adding basic page for typed signatures V3, V4 Dec 2, 2024
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c2b8851
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1fb6c4ee-94ae-4178-baed-67de570b67ee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 2, 2024
Copy link

sonarcloud bot commented Dec 3, 2024

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7ae6669
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10be2ac6-6aba-44a7-9821-135eededfa52

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant