chore: Stop suppressing pod install failures

[Gudahtt]

Description

Pod install failures were suppressed originally to make cross-platform development easier, as they would fail on Windows and Linux (where you would presumably be developing with Android which does not require this step). However, since the introduction of the new setup script, this step will not run on non-macOS machines by default so this error suppression is no longer needed.

This will make install errors easier to discover, saving developer time.

Related issues

N/A

Manual testing steps

To test that there is no regression, simply run yarn setup.

I'm not entirely sure how to induce a pod install error. But if you're in a state where pod install fails, then yarn setup should now fail as well, where previously it would succeed.

I simulated a failure by updating pod:install to say bundle exec po install (i.e. delete the d from pod so that it's an unrecognized command). This failure showed on the CLI as expected on this branch. On main it silently failed.

Screenshots/Recordings

N/A

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.04%. Comparing base (22a4989) to head (c2be77a).
Report is 70 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12485      +/-   ##
==========================================
+ Coverage   56.41%   57.04%   +0.63%     
==========================================
  Files        1797     1817      +20     
  Lines       40586    40875     +289     
  Branches     5097     5166      +69     
==========================================
+ Hits        22896    23318     +422     
+ Misses      16134    15974     -160     
- Partials     1556     1583      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gudahtt]

Depends upon #12574

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud