Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use max in send flow #13304

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: use max in send flow #13304

wants to merge 6 commits into from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Jan 31, 2025

Description

Fix support for the Use Max option in the send flow.

  • Ensure the maxValueMode prop is populated from the Redux state.
  • Skip controller state update if transaction metadata not yet added.

Also revert previous fix for the sake of minimum code.

Related issues

Fixes: #13215

Manual testing steps

See issue

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Jan 31, 2025
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner January 31, 2025 20:43
@matthewwalsh0 matthewwalsh0 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 358e863
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3b47da3-e11a-4a70-b67a-5fde1316a2fa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4a4b7cb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/57fb3b9c-0cff-48ae-b902-9a1755392cbf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: not able to send "Use Max" assets, always getting JSON-RPC error
1 participant