Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix sort feature #13277

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: fix sort feature #13277

merged 1 commit into from
Jan 30, 2025
+235 −124

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 30, 2025

Description

Fix a regression on sort token feature

Related issues

Fixes: #13260

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-01-30.at.20.36.20.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jan 30, 2025
@salimtb salimtb marked this pull request as ready for review January 30, 2025 19:49
@salimtb salimtb requested review from a team as code owners January 30, 2025 19:49
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a11eb98
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b870574-f096-4d90-88cc-0ad67f756047

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sethkfman
sethkfman approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit c28efe4 Jan 30, 2025
47 of 50 checks passed
@sethkfman sethkfman deleted the fix/fix-sort-feature branch January 30, 2025 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
4 participants
@salimtb @sethkfman @Prithpal-Sooriya @metamaskbot