Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Failing to add a token from the dapp #12501

Open
christopherferreira9 opened this issue Nov 29, 2024 · 2 comments
Open

[Bug]: Failing to add a token from the dapp #12501

christopherferreira9 opened this issue Nov 29, 2024 · 2 comments
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working

Comments

@christopherferreira9
Copy link
Contributor

christopherferreira9 commented Nov 29, 2024

Describe the bug

Calling wallet_watchAsset is not adding a token to the token list when called from dapps.
Call being made:

provider.request({
      method: 'wallet_watchAsset',
      params: {
        type: 'ERC20',
        options: {
          address: '0x2fF9853B6f102f280Ec926936b0b894135bE40Ff',
          symbol: 'TST',
          decimals: 4,
          image: 'https://metamask.github.io/test-dapp/metamask-fox.svg',
        },
      },
    });

Expected behavior

No response

Screenshots/Recordings

Screen.Recording.2024-11-29.at.4.37.48.PM.mov

Steps to reproduce

  1. Go to the MetaMask test dapp on the inapp browser
  2. Connect to the dapp
  3. Deploy an ERC20 token
  4. Tap Add Tokens to Wallet
  5. Approve -> Your token is not added to MetaMask

Error messages or log output

No response

Detection stage

During release testing

Version

7.37.0

Build type

None

Device

iPhone 11

Operating system

iOS, Android

Additional context

No response

Severity

No response

@christopherferreira9 christopherferreira9 added the type-bug Something isn't working label Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 29, 2024
@christopherferreira9 christopherferreira9 added the Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking label Nov 29, 2024
@metamaskbot metamaskbot added the regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 label Nov 29, 2024
@Unik0rnMaggie
Copy link
Contributor

Reproduced on Android 14 - Pixel 6 Pro.

Unable to add token from test dapp or coinmarketcap:

Add.token.failing.mov

@trezorsix
Copy link

Confirming, we have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

5 participants