Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Permitted networks on dapp connections #12500

Open
christopherferreira9 opened this issue Nov 29, 2024 · 0 comments
Open

[Bug]: Permitted networks on dapp connections #12500

christopherferreira9 opened this issue Nov 29, 2024 · 0 comments
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking type-bug Something isn't working

Comments

@christopherferreira9
Copy link
Contributor

christopherferreira9 commented Nov 29, 2024

Describe the bug

As of 7.37.0 (1501) when connecting to a dapp the user can update the permitted networks.
A few issues appear with this:

  1. The edit permitted networks dialog is non dismissible
  2. auto switches the active network

Expected behavior

No response

Screenshots/Recordings

edit_networks.mov

Steps to reproduce

For issue 1:

  1. Go to the metamask inapp browser
  2. Open the MetaMask test dapp
  3. Tap connect
  4. Edit the permitted chains to a different network to the one active
  5. Tap Connect on the modal
  6. On the "Add network permission" tap "Choose from permitted networks" -> try to dismiss the dialog

For issue 2:

  1. Follow issue 1 steps until 6
  2. Tap edit networks
  3. Select a chain different than the active chain and different from the initial selected in issue 1's steps
  4. Tap update -> This not only changes the permitted chains but also changes the active network

Error messages or log output

No response

Detection stage

During release testing

Version

7.37.0

Build type

None

Device

iPhone 11

Operating system

iOS

Additional context

No response

Severity

No response

@christopherferreira9 christopherferreira9 added the type-bug Something isn't working label Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 29, 2024
@christopherferreira9 christopherferreira9 added the Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking label Nov 29, 2024
@metamaskbot metamaskbot added the regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants