Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Spoof transaction domain while holding new tab scenario fails #12493

Open
Unik0rnMaggie opened this issue Nov 29, 2024 · 1 comment
Open

[Bug]: Spoof transaction domain while holding new tab scenario fails #12493

Unik0rnMaggie opened this issue Nov 29, 2024 · 1 comment
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@Unik0rnMaggie
Copy link
Contributor

Unik0rnMaggie commented Nov 29, 2024 •
edited by christopherferreira9
Loading

Describe the bug

While testing the Spoof transaction domain while holding new tab scenario from here, notice that it fails.

Expected behavior

The transaction domain should not change to the Portfolio domain

Screenshots/Recordings

Spoof.Tx.fail.mov

Steps to reproduce

  1. Open this link using the in-app browser
  2. Open a new tab with Portfolio
  3. Return to initial tab and click on Spoof transaction domain while holding new tab button
  4. Navigate to the tab switcher and hold your finger on the Portfolio tab
  5. Notice the transaction origin domain in the MetaMask confirmation changed to Portfolio domain

Error messages or log output

No response

Detection stage

During release testing

Version

7.37.0

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Device

Pixel 6 Pro- Android 14

Operating system

Android
iOS

Additional context

I obtained the build from here

Severity

1
@Unik0rnMaggie Unik0rnMaggie added the type-bug Something isn't working label Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 29, 2024
@metamaskbot metamaskbot added the regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 label Nov 29, 2024
@Unik0rnMaggie Unik0rnMaggie changed the title [Bug]: Spoof Tx fail - confirmation message incorrect [Bug]: Spoof transaction domain while holding new tab scenario fails Nov 29, 2024
@Unik0rnMaggie Unik0rnMaggie added the team-confirmations Push issues to confirmations team label Nov 29, 2024
@christopherferreira9
Copy link
Contributor

Suspected PR:
#12478

@Unik0rnMaggie Unik0rnMaggie added the Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metamaskbot @christopherferreira9 @Unik0rnMaggie