Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect message when adding network from Popular list #12492

Open
sleepytanya opened this issue Nov 29, 2024 · 5 comments
Open

[Bug]: Incorrect message when adding network from Popular list #12492

sleepytanya opened this issue Nov 29, 2024 · 5 comments
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

When a user adds a network from the Popular list, they encounter a message mentioning 'giving Undefined dapp origin permission', in 7.36.0 message didn't mention any dApps.
Additionally, if the user opts to 'Review' next to 'Network RPC URL', they are presented with a message that compares the current Infura RPC with a new one, such as https://flashbots.polygon-mainnet.com/.
Despite the incorrect message, this does not impact the functionality, and the network can still be successfully added using the default Infura RPC URL.

Expected behavior

Screenshots/Recordings

'Add custom network' message in 7.36.0 (1504):

File

Adding network 7.37.0 (1506):

addNetworkMessage.mov
Screenshot 2024-11-29 at 01 53 38 Screenshot 2024-11-29 at 01 54 02

Steps to reproduce

  1. Add a network from MM Popular list

Error messages or log output

No response

Detection stage

During release testing

Version

7.37.0

Build type

None

Device

iPhone 15

Operating system

iOS

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 labels Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 29, 2024
@Unik0rnMaggie
Copy link
Contributor

Reproduced on Android 14 - Pixel 6 Pro device:

add.network.mov

@Unik0rnMaggie
Copy link
Contributor

Same flashbots polygon message appears when trying to add popular networks via dapps like drpc or chainlist

Screenshot 2024-11-29 at 15 42 04 Screenshot 2024-11-29 at 15 44 17

@christopherferreira9
Copy link
Contributor

To add to this and because I figured it wasn't worth to have its own issue, the contents when adding a network via RPC are misaligned.

Screenshot 2024-11-29 at 5 06 24 PM

@Unik0rnMaggie
Copy link
Contributor

In version 7.37.0 (1511) warning still appears, but flashbots.polygon incorrect info disappeared:

Screen.Recording.2024-12-06.at.11.04.16.mov

@Unik0rnMaggie
Copy link
Contributor

Reproduced on QA build for Portfolio View feature, from here

Add.popular.network.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants