-
-
Notifications
You must be signed in to change notification settings - Fork 23
TODO: Deprecate in favor of webextension-polyfill #21
Comments
Here are the APIs detected by this package: https://github.com/MetaMask/extensionizer/blob/master/extension-instance.js#L1-L23 As we can see, this package only detects a subset of all web extension APIs. We detect one Chrome-specific API, namely In the readme of this package, we also find the following line:
Given all of the above, I don't think the intention of this package is to support non-standard features, and I think we can safely deprecate it in favor of |
I don't think we've ever relied on any non-standard interfaces. It might be nice to use some at some point, though. I could imagine shipping some enhancements to browsers that support the context menu API. As long as there is a way for us to detect that later, it's not a big deal, it still seems better to me to use a commonly relied on module rather than continue supporting some thing that mostly only we rely on. |
Possibly implementing this as part of MV3 work |
Actually disregard my previous comment. I think I've got it figured! |
The
webextension-polyfill
project has similar goals to this project, and offers a nicer API. We should consider deprecating this project in favor ofwebextension-polyfill
.I'm not entirely sure the goals of the two projects are the same though, as they explicitly don't want to support non-standard features. If that's something we want, then maybe it's still worth maintaining this project.
Edit by @rekmarks: We are going to do this.
The text was updated successfully, but these errors were encountered: