Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ERC-7746 for middleware hooks #32

Open
peersky opened this issue Nov 2, 2024 · 1 comment
Open

Use ERC-7746 for middleware hooks #32

peersky opened this issue Nov 2, 2024 · 1 comment

Comments

@peersky
Copy link

peersky commented Nov 2, 2024

noticed you guys are using extensively hooks in the enforcers.

It is very similar generic problem in the industry, e.g. Ironblocks and other companies implementing firewalls do same.

I’ve created https://ercs.ethereum.org/ERCS/erc-7746 to address this as generic industry problem so that we can have interoperable middleware hooks standard across industry.

I think you guys should contribute your ideas to it (and use it as a standard)!

@danfinlay
Copy link
Contributor

Requires we pack all our gator-specific params into the bytes memory configuration, but otherwise we surely could. Given that it's still only compatible with usage that explicitly involves encoding for it, how big do we think the win of reusing this interface would be?

I tend to think using agnostic input types like that are mostly useful when someone else is composing them (like in ERC-7710 redeemDelegation(bytes authority, Action action), where the authority is flexible but the caller is not expected to compose it. Since in this case the caller will basically always be packing it, my first thought is that the usage doesn't end up being very easily intercompatible, it just looks the same on the surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants