Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper calculation of percent time #84

Open
bencopl opened this issue Apr 11, 2023 · 0 comments
Open

Proper calculation of percent time #84

bencopl opened this issue Apr 11, 2023 · 0 comments

Comments

@bencopl
Copy link

bencopl commented Apr 11, 2023

The "% Time" column of the DrHook output format is calculated using the highest total walltime out of all the profiled regions. This is only valid if there are a pair of callipers encompassing the entire program.

DrHook tries to get around this by taking a note of the time at the first and last calls. We could implement something similar wherein we record the time between the profiler constructor and the final call to Profiler::stop but then we are making assumptions about where the constructor is called and it also becomes hard to take overhead into account.

@andrewcoughtrie andrewcoughtrie added this to the Release 0.3.0 milestone Aug 29, 2023
@andrewcoughtrie andrewcoughtrie removed this from the Release 0.3.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants