Add syntax highlighting support #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for embedded markdown and mermaid files
|
I'll have to investigate why the tests are failing before merging this. Also thinking to have a CD solution based in actions so that it would be easier to release new versions... |
|
Instead of having the syntax highlighting merged in this plugin, I've added an extension pack to the manifest so that installing this plugin installs also yours (298a7a9) |
|
That sounds like a good compromise. Want me to close this PR then? |
|
In the long term we should have a single plugin that handles the mermaid related features, but right now I'm not able to allocate much time to fix the pending issues in this repo... So, lets leave it open for now to keep it as a long term goal. Ok? |
|
Sounds good 👍! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #54.
Add syntax highlighting support for embedded markdown (identified as mermaid) and mermaid files. This code is the current latest from the side extension I spun off.
My thought is to maintain that as a separate extension both for people only wanting highlighting, and to keep the changes from causing noise here. I'll merge changes from there back to here as they use the same single syntax file.