Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - filter by OAuth scopes rather than x-internal flags #60

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

stueynz
Copy link

@stueynz stueynz commented Oct 23, 2020

In a non-trivial set of APIs with complex OAuth scopes; some clients want a 'simplified' openapi spec that covers just the stuff they're allowed to do.

So let's filter by --scopes allowing us to prune away the operations they're not allowed.

Recognised HTTP operations that don't have security element will be filtered based upon global security element as expected.

@MikeRalphson
Copy link
Contributor

Thanks, could you move the last commit to a new PR, as the functionality seems to be separate from the original intent?

@MikeRalphson
Copy link
Contributor

As I read this, the scopes option is mutually exclusive of the flags option. I can see the reason from a code perspective, but wonder if it is what users will expect. We at least need to call it out and warn if both are selected.

@MikeRalphson
Copy link
Contributor

Hi, appreciate it has been a long time, but if you're still interested in this PR, could you fix up the lint errors/warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants