This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
chore: build the package with another target #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was asked in #39 This add a new target for building the package.
sileht
reviewed
Apr 7, 2021
| entry: './src/Crisp.jsx', | ||
| output: { | ||
| path: path.resolve(__dirname, './dist/web/'), | ||
| filename: 'crisp-web.js', |
There was a problem hiding this comment.
I'm afraid, this will break update of the existing installation.
| path: path.resolve(__dirname, './dist/module/'), | ||
| filename: 'crisp-module.js', | ||
| library: { | ||
| type: 'module', |
There was a problem hiding this comment.
Why module? and not one of the 17 built-in other ways to generate a javascript file with webpack?
I'm not a huge fan of maintaining different versions of the same lib. Most frameworks support 'es' and commonjs1/2 import style. vitejs seems to have an issue with the latter, not sure we should support multiple formats just for one framework.
There was a problem hiding this comment.
You're right. So I close this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm new with many aspect of Javascript I need to be sure this really fix the issue #39 before we merged it.
Did anyone could help ?