Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improvement #16

Open
Galeath opened this issue May 22, 2021 · 14 comments
Open

Suggestions for improvement #16

Galeath opened this issue May 22, 2021 · 14 comments

Comments

@Galeath
Copy link

Galeath commented May 22, 2021

A couple of suggestions for improvement for the bot to function better in multiplayer lobbies.

  • Password change tolerance
  • DT/NC stopper
  • Map rotate

1st. Password change tolerance
If someone spam changes the password to try and get the bot spamming !mp password, silencing the bot and player, the bot should have a tolerance to check who is the host when changing passwords and ban the changer of passwords.

2nd. DT/NC/HR stopper
When a map is picked, and the star rating after adding DT/NC or HR* (*in nomod mode) is higher than the set regulation, the mods will be disabled and reset back to freemod or nomod. If the player constantly tries to redo the mods back into DT/NC or HR, the bot will do number 3.

3rd. Map rotating
If a player continually picks maps higher than the current regulation star maximum/minimum or length maximum/minimum, the host will auto-rotate the host to the next person in the queue.

@Trollcraft1002
Copy link

Suggestion for command if possible tho: !kick "player" - starts vote for player to be kicked

@Meowhal
Copy link
Owner

Meowhal commented Jul 17, 2021

1st. Password change tolerance

Is it possible for anyone other than the room creator to change the lobby password?
I couldn't find a way to do it.

2nd. DT/NC/HR stopper

we can check current active mods using "!mp settings" command.
but the command is expensive. I don't want to run that command often.
Another option is to check the match history after the match starts and abort the match if the dt/nc mod is valid. However, it should be very stressful for players to stop the game after it actually starts.
For that reason, I am having trouble dealing with the problem.

3rd. Map rotating

In fact, that behavior was implemented once, but is now disabled.
This punishing behavior can create a strong antipathy to the player.
I will be able to enable it as an option on request.

!kick "player"

I want to implement it if I can afford it. I am also considering a function that automatically kicks the AFK player.

@Band-age
Copy link

Band-age commented Jul 17, 2021

!kick "player"

I want to implement it if I can afford it. I am also considering a function that automatically kicks the AFK player.

I like the idea of the irc client automatically kicking afk players. Could there be a way for someone to voluntarily set themselves as afk if they want to skip the next beatmap to take a break? I see that this auto host bot has that feature and I feel like it'd be interesting to implement (look for the !afk command) (https://github.com/tempaccount140/osu-auto-host).

Also I wanted to mention that a friend and I figured out that we were able to kick people by using the !mp kick username command if you were the creator of the lobby, or you are a referee of the lobby (do !addref username to add people as a ref) (https://osu.ppy.sh/wiki/en/osu%21tourney/Tournament_Management_Commands).

Understandable with the DT/NC stopper being difficult to implement. In the meantime, I suppose we can just micromanage that with the creator of the lobby and any additional referees in the lobby trying to prevent the current host using DT or NC for trolling or when a majority of the lobby doesn't want it turned on.

Been having fun using this irc client in my lobby and I feel like this makes for a great osu multiplayer experience so far. Can't wait to see more updates with this.

@Galeath
Copy link
Author

Galeath commented Jul 17, 2021

Alright thanks for the update Meowhal

@capthusky
Copy link

1st. Password change tolerance

Is it possible for anyone other than the room creator to change the lobby password?
I couldn't find a way to do it.

2nd. DT/NC/HR stopper

we can check current active mods using "!mp settings" command.
but the command is expensive. I don't want to run that command often.
Another option is to check the match history after the match starts and abort the match if the dt/nc mod is valid. However, it should be very stressful for players to stop the game after it actually starts.
For that reason, I am having trouble dealing with the problem.

3rd. Map rotating

In fact, that behavior was implemented once, but is now disabled.
This punishing behavior can create a strong antipathy to the player.
I will be able to enable it as an option on request.

!kick "player"

I want to implement it if I can afford it. I am also considering a function that automatically kicks the AFK player.

Is there a way to implement a username checker? There's lots of troll out there and I think it would be great to add a "Exclusion" list or basically ban list due to repeat offending and trolling the lobby.

And also is it possible to implement lobby name checker? Incase if people keep changing the original lobby name

@Meowhal
Copy link
Owner

Meowhal commented Sep 20, 2021

Is there a way to implement a username checker? There's lots of troll out there and I think it would be great to add a "Exclusion" list or basically ban list due to repeat offending and trolling the lobby.

Implemented the deny list function in version 1.5.3.
Players added to the list will be able to join the lobby, but will no longer be queued in the Host Order list.

The list can be written to the configuration file (./config/local.json) or modified at any time using the *denylist add [username] and *denylist remove [username]commands. Please note that players added by the command will not be inherited after the bot is restarted.

And also is it possible to implement lobby name checker? Incase if people keep changing the original lobby name

The bot can see the current lobby name through the lobby history only at the beginning of the match. If someone changes the lobby name, the following log will be output.

lobbyname changed : 4.50-5.59 AHR -> 4.5-5.5 | Auto Host Rotation, host : someone

However, the bot does not have the ability to change the lobby name.
What do you want when a lobby name change is detected?

@capthusky
Copy link

Is there a way to implement a username checker? There's lots of troll out there and I think it would be great to add a "Exclusion" list or basically ban list due to repeat offending and trolling the lobby.

Implemented the deny list function in version 1.5.3.
Players added to the list will be able to join the lobby, but will no longer be queued in the Host Order list.

The list can be written to the configuration file (./config/local.json) or modified at any time using the *denylist add [username] and *denylist remove [username]commands. Please note that players added by the command will not be inherited after the bot is restarted.

And also is it possible to implement lobby name checker? Incase if people keep changing the original lobby name

The bot can see the current lobby name through the lobby history only at the beginning of the match. If someone changes the lobby name, the following log will be output.

lobbyname changed : 4.50-5.59 AHR -> 4.5-5.5 | Auto Host Rotation, host : someone

However, the bot does not have the ability to change the lobby name.
What do you want when a lobby name change is detected?

Was suggesting if it's possible to provide the ability to keep lobby name for the bot, like instead of keep size it's keep lobby name, and will revert back any changes to the previous name set initially or manually typed in config files. I'm not sure how it will work or if it's even gonna work haha

For the Map Rotating is it possible to turn it back on? Like setting maximum of 3 violation before the host was passed to someone else

@Meowhal
Copy link
Owner

Meowhal commented Sep 20, 2021

Unfortunately, We cannot change the lobby name from the bot. osu's bancho does not provide such a feature. Only the host can change manually.

For the Map Rotating is it possible to turn it back on? Like setting maximum of 3 violation before the host was passed to someone else

Am I correct in understanding that if the host selects a map that violates the rules more than a certain number of times, the host will move on to the next person?
I'll try to implement it.

@AuracleTech
Copy link

Im not sure if this fits on this particular ticket, but the freemod reset each map if it was already freemod removes everyone's mod and after a while its really annoying I try to HR all maps
Can you detect if freemod has been changed?

@Meowhal
Copy link
Owner

Meowhal commented Oct 20, 2021

thank you for let me know
Changed the behavior of the lobby keeper in the latest version. The command will only be executed when needed

@sleeping247
Copy link

sleeping247 commented Oct 28, 2021

2nd. DT/NC/HR stopper

we can check current active mods using "!mp settings" command. but the command is expensive. I don't want to run that command often. Another option is to check the match history after the match starts and abort the match if the dt/nc mod is valid. However, it should be very stressful for players to stop the game after it actually starts. For that reason, I am having trouble dealing with the problem.

in reference to this, if you pick a map that is under the violation range but with dt is in the range, the bot will give you a violation even though the map is technically in range.

3rd. Map rotating

In fact, that behavior was implemented once, but is now disabled. This punishing behavior can create a strong antipathy to the player. I will be able to enable it as an option on request.

ties into the statement above, until 2nd is solved you should probably change the dialogue of the violation to let people know that dt currently doesn't work so people dont try to put other dt maps. As i had just encountered the issue and had it auto skip me cuz I had no idea dt was broken

@Meowhal
Copy link
Owner

Meowhal commented Oct 28, 2021

Sorry for the inconvenience. I'll add a message that dt not work correctly.

@Meowhal
Copy link
Owner

Meowhal commented Oct 28, 2021

I'm wondering if there's a way to find out the difficulty of the map that applied some mods.

@ZeroPyrozen
Copy link
Contributor

I'm wondering if there's a way to find out the difficulty of the map that applied some mods.

This would require star rating calculator from osu!lazer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants