Fixed Theatre of War Faction Checks #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised log levels from info to debug in AutoAwardsTableModel and AutoAwardsDialog to reduce verbosity in normal operation. This adjustment ensures that detailed internal state information is logged only when debug logging is enabled, which aids in troubleshooting without cluttering standard logs.
Reordered parameters in the processFaction method call to ensure proper functionality. Removed unnecessary instanceof check for AtBContract when verifying campaign options usage. These changes improve code accuracy and reliability in processing faction details.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5307 +/- ##
============================================
- Coverage 10.47% 10.47% -0.01%
+ Complexity 6069 6063 -6
============================================
Files 959 959
Lines 135559 135561 +2
Branches 19750 19751 +1
============================================
- Hits 14204 14196 -8
- Misses 119997 120013 +16
+ Partials 1358 1352 -6 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordered parameters in the
processFactionmethod call to ensure proper functionality. Fixed call fetching employer faction, to correctly call faction code. Changed log message levels to debug - these were missed when I lowered the logging level of the majority of the internal autoAwards logger messages.Fixes #5301