Issue 5256: Refactored MekHQ Unit's Gunners to be Set to ensure gunners are unique #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we have some failing tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5295 +/- ##
=========================================
Coverage 10.48% 10.48%
- Complexity 6067 6070 +3
=========================================
Files 959 959
Lines 135515 135562 +47
Branches 19743 19750 +7
=========================================
+ Hits 14202 14207 +5
- Misses 119957 120002 +45
+ Partials 1356 1353 -3 ☔ View full report in Codecov by Sentry. |
psikomonkie
changed the title
|
Fixes #5256 |
IllianiCBT
changed the title
IllianiCBT
reviewed
Dec 12, 2024
| List<Person> gunners = Collections.nCopies(gunnerCount, crewMember); | ||
|
|
||
| Set<Person> gunners = new HashSet<>(); | ||
| for(int i = 0; i < gunnerCount; i++){ |
There was a problem hiding this comment.
Let's pop a whitespace after for
IllianiCBT
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rs are unique
Fixes #5256