Removed Predictable Scenario Generation Schedule #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new "Sector" column in ScenarioTableModel to display sector information. Enhanced scenario generation by implementing weekly scenario date generation and daily scenario scheduling based on campaign and contract conditions, improving dynamic campaign management. These changes optimize the scenario planning process and improve overall gameplay experience.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5286 +/- ##
==========================================
Coverage 10.47% 10.47%
- Complexity 6052 6065 +13
==========================================
Files 959 959
Lines 135253 135505 +252
Branches 19684 19742 +58
==========================================
+ Hits 14169 14199 +30
- Misses 119733 119953 +220
- Partials 1351 1353 +2 ☔ View full report in Codecov by Sentry. |
|
Added more intelligent force picking for Integrated contracts. Previously it would just pick a random force from a list of available combat forces. Now it creates a pool with intact forces having a higher chance of being picked over less operational forces. |
Streamlined the `determineLayeredForceIconOperationalStatus` method with a switch expression for clarity and efficiency. Improved the force assignment logic in `StratconRulesManager` to better handle force selection and ensure operational units have an increased chance of assignment. Enhanced code readability and reduced potential for errors by using modern collection methods.
Replaced the linear calculation with a quadratic formula to determine the operation status. This change aims to provide a more balanced scaling of operation status relative to the unit count.
The removal logic for force IDs was corrected to ensure proper conditional execution within the 'autoAssignLances' block. This change prevents force IDs from being erroneously retained, eliminating potential conflicts between force assignments. The adjustment maintains correct indexing by moving the removal operations inside the conditional block.
|
@IllianiCBT Merge Conflicts |
# Conflicts: # MekHQ/src/mekhq/campaign/stratcon/StratconCampaignState.java # MekHQ/src/mekhq/campaign/stratcon/StratconRulesManager.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously scenarios would always be spawned on a Monday, with the player having advanced notice for all scenarios that would be encountered that week. I've received a lot of feedback over the past months from the dev team and streamers that this creates a very predictable timetable of affairs which, while very civilized, removes a lot of tension from deployments.
Now, every Monday, we make scenario rolls as normal. For every scenario scheduled we secretly store a date. On that date we will spawn the scenario. The player will still have some forewarning, based on the deployment time for the chosen sector, however this makes engagements a lot less predictable.