Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows to select a previous engineer or new crew member to activate large vessels #5253

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Nov 26, 2024

Because we have the concept of "engineer" inside MM to handle the self-healing properties of large vessels, funcitonalities like "mothball" and "activate" are compromised due to them requiring a tech.

This fix does two things:

  • fix Can't Activate Dropship #4529, it does that by adding the previous "engineer" to the crew of the mothballed vessel.
  • Adds vessel techs to the selection of techs in the "select a techie" drop down window when you want to activate a unit.

The later was necessary to deal with a rare but possible situation. If the engineer that originally mothballed the large vessel (present in the mothballInfo object) is not active, or were removed/sacked by any reason then they would not be available to activate the ship, this means that the ship would be locked in a situation that could only be circunvented by GM activating.

PS.: I hope the second change does not cause any trouble

@Scoppio Scoppio self-assigned this Nov 26, 2024
@Scoppio Scoppio added the Bug label Nov 26, 2024
@Scoppio Scoppio force-pushed the fix-activate-large-vessel branch from b5a922c to a5e6b44 Compare November 26, 2024 02:00
@Scoppio Scoppio force-pushed the fix-activate-large-vessel branch from a5e6b44 to e9da4f6 Compare November 26, 2024 02:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.49%. Comparing base (519101f) to head (e9da4f6).
Report is 44 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5253      +/-   ##
============================================
- Coverage     10.50%   10.49%   -0.01%     
+ Complexity     6044     6043       -1     
============================================
  Files           957      957              
  Lines        134716   134760      +44     
  Branches      19572    19587      +15     
============================================
- Hits          14149    14145       -4     
- Misses       119216   119266      +50     
+ Partials       1351     1349       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit af1d231 into MegaMek:master Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Activate Dropship
4 participants