Reworked StratCon Sector Sizes & Initialize State #5229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the calculation of planetary diameter to the initialization of StratconTrackState. This allows the track size to be set proportionally based on the planet's surface area, ensuring more realistic and varied gameplay environments.
Added null checks throughout Stratcon scenario generation methods to handle potential null scenarios. Created new methods and updated existing ones to ensure robust error handling and to return null if scenario creation fails.
Implemented a `getSize` method to calculate the track size based on width and height. This change enhances the functionality by providing a straightforward way to retrieve the total size of the track. Additionally, minor formatting adjustments were made for code consistency.
Added logic to seed sectors with hidden forces based on contract type in StratconContractInitializer. Differentiated scenario creation between garrison, raid, pirate hunting, and planetary assault contracts.
Modified contract generation to prevent full-scale invasions for pirate hunting contracts. Adjusted multiplier settings to treat guerrilla warfare similarly to raid types. These changes enhance the accuracy and realism of mission deployment scenarios.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5229 +/- ##
============================================
- Coverage 10.52% 10.50% -0.02%
+ Complexity 6044 6041 -3
============================================
Files 957 957
Lines 134523 134593 +70
Branches 19545 19565 +20
============================================
- Hits 14153 14145 -8
- Misses 119021 119095 +74
- Partials 1349 1353 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things.
First it adds more robust checks and balances to the method added in 50.01 that allows easy addition of new scenarios to a StratCon Track (aka sector). It also adds the ability to insert hidden scenarios into a StratCon Track. This is taken from the in-dev Logistics Module.
Previously the size of a StratCon Track was determined by the number of lances required by the contract. Now Tracks are sized according to the surface area of the planet the contract is based on. This substantially increases the size of Tracks by design. This is in preparation for a major 2025 project that we're not ready to discuss at this time. Developers, if you're not aware of what this alludes to, and want to know, ask in the Developer chat. :)
Finally, using the new method that allows us to add non-objective scenarios to the StratCon Track, we now seed enemy forces on Tracks prior to the players' arrival. These are fixed hidden scenarios (i.e. they will always be there until found and resolved). The number of hidden enemy forces is based on the size of the Track and the type of contract:
Garrison or Pirate Hunting: None
Raid or Guerrilla Warfare: Track Size / 10
Planetary Assault: Track Size / 5
Other: Track Size / 20
These values are then modified by the scenario spawn chance for the contract.
These pre-seeded fixed forces are also required for the 2025 project.