-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Resupply Module #4518 - MekHQ not recognizing Cargo Mek's cargo capacity, relevant for Logistics Overhaul/Upgrade #5324
Comments
So the issue here is that these aren't cargo bays, they're fixed values of 'cargo'. So it's not saying that the unit has I suspect this is a legacy decision, but @HammerGS might be able to weigh in as to how best to handle this. Because quite rightfully, players are going to see this and mentally parse it as cargo capacity. |
To put my two cents in; the unit obviously isn't carrying around a black box that is labelled 'cargo' - it seems that it could only function as a container that could be reasonably filled, used to transport, and then emptied. I think it definitely should count as cargo capacity for the purposes of Mekhq/stratcon if nothing else. |
This issue is one of internals - I'm inclined to agree with you - but this value appears to be just stored as a String and not as a definitive Part we can directly interact with. Meaning any parsing would need to be String-based -- i.e. checking whether the String Not to mention we'd need to parse every part on the unit to find the 'cargo' parts. |
I went ahead and implemented String comparison. It's not idea, but I strongly agree that these units should correctly report their cargo capacity and short of introducing an entirely new Part type (and then making that backwards compatible) I'm failing to spy a better alternative. |
Prerequisites and Pre-Issue Checklist
I'm reporting the issue to the correct repository:
MegaMek
MegaMekLab
MekHQ
I've tested the issue against at least the latest MILESTONE version
I've asked on the MegaMek Discord about the error
I've reviewed the BattleTech rules and MekHQ documentation, and I've confirmed that something isn't working as intended.
I've searched the Github tracker and haven't found the issue listed
Severity *
Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.
Brief Description *
Using two salvaged Daedalus 'meks, I was trying to get a convoy working, and got it set up and assigned. The issue presents in MekHQ - it does not recognize the meks as having any cargo capacity. It picks up 4.35 tons from an insulated cargo space on a Coolant Truck (Hover) and truncates to 4 tons, but does not pick up the combined 30 tons in the two stock Daedalus GTX2A 'Stevedore' meks. This is relevant for satisfying logistical requirements for the resupply feature.
Steps to Reproduce
No response
Operating System *
Windows 10
Java Version *
17
MekHQ Suite Version *
None
Custom MekHQ Version
Implemented Resupply Module #4518
Attach Files
No response
Final Checklist
The text was updated successfully, but these errors were encountered: