Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Working Bridgelayer #4199

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

pheonixstorm
Copy link
Collaborator

@pheonixstorm pheonixstorm commented Feb 22, 2023

This PR still needs a lot of work, but it also has a few issues I need help with finding solutions to improve the code.

  1. Need to set exits: This can easily be done manually I believe, but I would rather find a way to do it within the software that already exsists.
  2. There is an NPE that pops up when you mouseover the new bridge hex (log below). I haven't looked into it yet so I may find a fix before it gets a once over.
  3. Abstract the getter and setter and override in the appropriate entity class or just let entity handle everything as coded now?

Items still to do: TW p131

  1. Create a second bridge terrain BRIDGE2 to use for bridges over water. Per rules bridges created using a bridgelayer have double the weight capacity of the CF listed only if placed on the water. If the land hex is higher it remains unchanged.
  2. SV vehicles with bridgelayers can have the bridgelayer destroyed if the turret is hit.
  3. Setup infantry bridging engineers. So far I have touched this yet.
  4. Finish coding water bridging. So far only Heavy Bridgelayer is working

NOTE: when completed this will be closed, cleaned up, rewritten, and reposted.

@pheonixstorm pheonixstorm added (RFE) Enhancement Requests for Enhancement, new features or implementations For New Dev Cycle This PR should be merged at the beginning of a dev cycle labels Feb 22, 2023
@pheonixstorm
Copy link
Collaborator Author

Forgot a couple things.
megamek.log
bridge

@pheonixstorm
Copy link
Collaborator Author

So I tried again and went to a new movement phase and came across some new NPEs from Princess
megamek.log

@SJuliez SJuliez removed the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Mar 6, 2023
@HammerGS HammerGS added the In Development (Draft) An additional way to mark something as a draft. Make it stand out more. label May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Development (Draft) An additional way to mark something as a draft. Make it stand out more. (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants