Add support for AppImage, Snap, RPM #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to build AppImages, Snap, and RPM.
Built files are available here for testing : https://github.com/romainrbr/emby-theater-electron/releases/tag/3.0.12
To build those file locally :
This will create a
distfolder, with all the requested file.The icon file was as well switch to PNG (as well as 512x512) so it would be supported with AppImage.
To run the releases :
AppImage : Just chmod+x, and run the file
Emby.Theater-3.0.12.AppImageRPM : Install it with
rpm -i emby-theater-3.0.12.x86_64.rpmSnap :
snap install --dangerous emby-theater_3.0.12_amd64.snapShould close #54
Edit: After some testing, it appears that video playing without using an external player doesn't work (same symptoms as running the code on a Fedora box)