Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] il faut une critique d'un article en français #1

Open
rmcminds opened this issue Jan 2, 2023 · 0 comments
Open

[example] il faut une critique d'un article en français #1

rmcminds opened this issue Jan 2, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@rmcminds
Copy link
Contributor

rmcminds commented Jan 2, 2023

This is an example issue; you may use an abbreviated version if you and your partner are familiar with the system. If you don't have a defined partner, an issue like this could be used to try to find one.


There is a new article review by french language learner Ryan McMinds, which needs critique by someone skilled in French:

https://github.com/McMinds-Lab/multilingual_journal_club/blob/main/000_example/fran%C3%A7ais/rmcminds_revue.md


Please directly edit the file by creating a pull request with the suggested changes.

To do this, you will need to create a new branch or fork of the repository (basically, a copy, which doesn't directly affect the main branch). This should be automatically prompted when you click to edit the file in the browser. You will then need to create a new pull request to merge your branch into the main branch. You should assign the pull request to the person who originally wrote the review, so that they can approve it and complete the merge. The main branch will then have the updated version of the review, and you can use the compare tool to see the differences between the old version and the new one.

If you feel it would be worthwhile, you may create a new file in the same directory, with summary notes about the changes. This could be added to the same branch as the edits, in which case a single pull request will both make the changes and add the new file.

@rmcminds rmcminds added the good first issue Good for newcomers label Jan 3, 2023
@rmcminds rmcminds pinned this issue Jan 3, 2023
@rmcminds rmcminds changed the title [example] Il faut une critique d'article en français [example] il faut une critique d'un article en français Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant