Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rftools modular storage dupes IC2c stacked crafting recipes #84

Open
Saereth opened this issue Nov 18, 2023 · 5 comments
Open

Rftools modular storage dupes IC2c stacked crafting recipes #84

Saereth opened this issue Nov 18, 2023 · 5 comments

Comments

@Saereth
Copy link

Saereth commented Nov 18, 2023

MC version: 1.19.2
Forge: 43.3.5
Ic2c: IC2Classic-1.19.2-2.0.8.jar
Rftools: rftoolsstorage-1.19-4.1.2.jar
Mcjtylib: mcjtylib-1.19-7.2.5.jar

Crafting any recipe that uses ic2c stacked crafting results in tons of materials being duplicated, here is a video of it happening:

rftoolsbug.mp4
@Speiger
Copy link

Speiger commented Nov 18, 2023

@McJty to provide a bit of insight.
StackCrafting takes the ingredients in the "getRemainingItems" function and subtract's them and returns them back to you.
Basically taking over the entire subtraction process.

This shouldn't be to hard to be accounted for.

@McJty
Copy link
Collaborator

McJty commented Nov 19, 2023

@Speiger StackCrafting? What? I don't understand

@Speiger
Copy link

Speiger commented Nov 19, 2023

@McJty Stackcrafting is the ability to consume more then 1 item in a slot.
So you can have recipes like this:
javaw_MfcEHldHKL

The idea being instead of creating 5 layers of components you simply craft more of common items you need/have anyways.

@McJty
Copy link
Collaborator

McJty commented Nov 19, 2023

Hmm that's going to be very hard to support. To fix the duping problem I think I'm just going to disallow recipes like that. At least for now

@Speiger
Copy link

Speiger commented Nov 19, 2023

@McJty i looked into your code.
This isn't a problem of how you handle the crafting recipe.
https://github.com/McJtyMods/RFToolsStorage/blob/1.19/src/main/java/mcjty/rftoolsstorage/craftinggrid/StorageCraftingTools.java#L152

The assemble/getRemainingItems function looks exactly the same on how i implemented it.
So that is correct.

The thing I noticed.
It only consumes the None Oredicted items. (Watercell)
But oredicted items (Tin Ingot) just get duplicated and not consumed. (So only created)

So this looks like that RFStorage has issues with Oredicted items specifically, and not stackcrafting itself.
Because cells get consumed correctly.
Stackcrafting might just amplify the oredict issue RFStorage has in general. (Already seen videos where multi choice items as ingredients simply won't work in general)

I hope that helps you.

(I tested it in my dev space to make sure ic2c isn't the problem here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants