Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Support Resource Packs for Dimensional Shard Ore #76

Open
HalcyonSeas73 opened this issue Apr 18, 2022 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@HalcyonSeas73
Copy link

I've noticed that the Dimensional Ores don't seem to support resource packs; Lothrazar's Elementary Ores seems to support them, I thought it would help the ores mesh nicely.

Example:
Untitled

@McJty
Copy link
Collaborator

McJty commented Apr 19, 2022

Of course it accepts resource packs. You have to replace the texture itself though

@HalcyonSeas73
Copy link
Author

Of course it accepts resource packs. You have to replace the texture itself though

Personally, I'm not very familiar with doing so. How are other mods able to use a resource pack's texture for, say, stone? It would be impossible to add "compatibility" for each and every resource pack; can it not be done dynamically via the mod?

Another clearer example; the "netherrack" portion of the ore seems to be 'hardcoded', rather than respecting the resource pack.
Untitled

@HalcyonSeas73
Copy link
Author

Alright, so, further information: having the base texture as per the resource pack, then having the ore as an overlay, via a custom block json, rather than something hardcoded. This is the one Elementary Ores uses.

@McJty McJty added the enhancement New feature or request label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants