Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent variable names, script names & hard-coded things #80

Open
1 of 6 tasks
shen4brains opened this issue Dec 7, 2020 · 3 comments
Open
1 of 6 tasks
Assignees
Labels
enhancement New feature or request

Comments

@shen4brains
Copy link
Member

shen4brains commented Dec 7, 2020

Things to clean up:

  • subject directory variable naming conventions (e.g., $subjdir, $direc, $baseDir are all used to mean the same directory)
  • turn off verbose mode in bb_eddy_wrap and bb_probtrackx2
  • rename TVB team scripts with 'tvb_' prefix (e.g., probtrackx scripts)
  • rename IDP pipeline bb_IDP.py to be consistent with other subpipes

Hard-coded things to fix:

  • B0 extraction in diffusion subpipe << This is an issue for the odd case where B0 isn't the first volume
  • acqparams.txt contents in bb_pre_eddy
@shen4brains shen4brains added the enhancement New feature or request label Dec 7, 2020
@shen4brains shen4brains self-assigned this Dec 7, 2020
@shen4brains
Copy link
Member Author

shen4brains commented Jan 19, 2021

Also some typos that don't affect pipeline function:

  • extra subject name argument in FEAT job submission in bb_pipeline_func in both ADNI3 and master branches

@shen4brains
Copy link
Member Author

Also need to check for consistent labelling of QC report with pipeline sections (e.g., 'dMRI' not 'DTI', 'structural' not 'anatomical')
@justinliuyuwang

@shen4brains
Copy link
Member Author

And make logging of jobFC equivalent to other logs (missing header and footer?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant