Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 3.6] Move test helper code to the framework repo #9011

Conversation

davidhorstmann-arm
Copy link
Contributor

Trivial 3.6 backport of #8992

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review labels Apr 4, 2024
Copy link
Contributor

@Ryan-Everett-arm Ryan-Everett-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update them instead to refer to framework/include, where the contents
of tests/include have been moved.

Signed-off-by: David Horstmann <[email protected]>
tests/CMakeLists.txt now refers correctly to framework/include rather
than tests/include.

Signed-off-by: David Horstmann <[email protected]>
This all.sh component specifies a path directly so needs editing to
point into the framework submodule.

Signed-off-by: David Horstmann <[email protected]>
These have now been moved to framework/src and framework/include,
respectively.

Signed-off-by: David Horstmann <[email protected]>
The MBEDTLS_TEST_PATH variable now points into the framework submodule,
along with other ad-hoc paths in the Makefiles.

Signed-off-by: David Horstmann <[email protected]>
These are references that are part of the PSA shared memory testing
work and thus were not previously updated.

Signed-off-by: David Horstmann <[email protected]>
@davidhorstmann-arm davidhorstmann-arm changed the base branch from development to mbedtls-3.6 April 9, 2024 17:37
Copy link
Contributor

@Ryan-Everett-arm Ryan-Everett-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeout failure on Internal CI looks spurious (OpenCI passed). LGTM

@davidhorstmann-arm
Copy link
Contributor Author

Will be superseded by the backport of #9409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants