-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 3.6] Move test helper code to the framework repo #9011
Closed
davidhorstmann-arm
wants to merge
8
commits into
Mbed-TLS:mbedtls-3.6
from
davidhorstmann-arm:move-test-code-to-framework-3.6
Closed
[Backport 3.6] Move test helper code to the framework repo #9011
davidhorstmann-arm
wants to merge
8
commits into
Mbed-TLS:mbedtls-3.6
from
davidhorstmann-arm:move-test-code-to-framework-3.6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhorstmann-arm
added
needs-review
Every commit must be reviewed by at least two team members,
needs-ci
Needs to pass CI tests
needs-reviewer
This PR needs someone to pick it up for review
labels
Apr 4, 2024
4 tasks
Ryan-Everett-arm
previously approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
davidhorstmann-arm
force-pushed
the
move-test-code-to-framework-3.6
branch
from
April 9, 2024 17:35
14ba492
to
ff49ad8
Compare
Signed-off-by: David Horstmann <[email protected]>
Update them instead to refer to framework/include, where the contents of tests/include have been moved. Signed-off-by: David Horstmann <[email protected]>
tests/CMakeLists.txt now refers correctly to framework/include rather than tests/include. Signed-off-by: David Horstmann <[email protected]>
This all.sh component specifies a path directly so needs editing to point into the framework submodule. Signed-off-by: David Horstmann <[email protected]>
These have now been moved to framework/src and framework/include, respectively. Signed-off-by: David Horstmann <[email protected]>
The MBEDTLS_TEST_PATH variable now points into the framework submodule, along with other ad-hoc paths in the Makefiles. Signed-off-by: David Horstmann <[email protected]>
These are references that are part of the PSA shared memory testing work and thus were not previously updated. Signed-off-by: David Horstmann <[email protected]>
Signed-off-by: David Horstmann <[email protected]>
davidhorstmann-arm
force-pushed
the
move-test-code-to-framework-3.6
branch
from
April 9, 2024 17:36
ff49ad8
to
98f15f6
Compare
Ryan-Everett-arm
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeout failure on Internal CI looks spurious (OpenCI passed). LGTM
Will be superseded by the backport of #9409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ci
Needs to pass CI tests
needs-review
Every commit must be reviewed by at least two team members,
needs-reviewer
This PR needs someone to pick it up for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial 3.6 backport of #8992
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")